Skip to content

windows: expose reparse buffer types #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

windows: expose reparse buffer types #260

wants to merge 1 commit into from
+17 −3

Conversation

tomgr
Copy link

@tomgr tomgr commented Aug 22, 2025 •
edited
Loading

These are needed for interacting with reparse buffers on Windows.
Searching on github reveals a lot of repositories that have copied these
types, so it would make sense to export them directly.

This also copies a method on SymbolicLinkReparseBuffer from
go/src/internal/syscall/windows/reparse_windows.go to ease interacting
with symbolic links.

@tomgr
windows: expose reparse buffer types
9c46a42 
These are needed for interacting with reparse buffers on Windows.
Searching on github reveals a lot of repositories that have copied these
types, so it would make sense to export them directly.

This also copies a method on SymbolicLinkReparseBuffer from
go/src/internal/syscall/windows/reparse_windows.go to ease interacting
with symbolic links.
@tomgr tomgr mentioned this pull request Aug 22, 2025
Merged
@gopherbot
Copy link
Contributor

This PR (HEAD: 9c46a42) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/698435.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/698435.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Thomas Gibson-Robinson:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/698435.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomgr @gopherbot